Remove -Zemscripten-wasm-eh#156928
Open
bjorn3 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Some changes occurred in cfg and check-cfg configuration cc @Urgau |
rustbot
added
A-LLVM
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
bjorn3
commented
May 25, 2026
| /// Allows using anonymous lifetimes in argument-position impl-trait. | ||
| (unstable, anonymous_lifetime_in_impl_trait, "1.63.0", None), | ||
| /// Allows access to the emscripten_wasm_eh config, used by panic_unwind and unwind | ||
| (internal, cfg_emscripten_wasm_eh, "1.86.0", None), |
Member
Author
There was a problem hiding this comment.
I haven't moved this to the list of removed features as it is an internal feature.
Member
Author
|
@purplesyringa @hoodmane @curiousdannii @kripken @aheejin (I hope I didn't forget any major stakeholder) Has it indeed been long enough since switching to wasm exceptions by default that we can safely remove this flag? |
Contributor
|
It's fine with me. I won't ever be turning it off again. |
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
emscripten_always_wasm_eh
branch
from
5ac842d to
802c141
Compare
purplesyringa
added a commit
to iex-rs/lithium
that referenced
this pull request
May 25, 2026
Upstream PR: rust-lang/rust#156928
Contributor
|
Happy to see this finally happen! No concerns on my side. |
This comment has been minimized.
This comment has been minimized.
|
I'm now using panic=abort, so I think it doesn't matter for me. |
bjorn3
force-pushed
the
emscripten_always_wasm_eh
branch
from
802c141 to
be3e3c7
Compare
Collaborator
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
bjorn3
force-pushed
the
emscripten_always_wasm_eh
branch
from
be3e3c7 to
24d9697
Compare
This comment has been minimized.
This comment has been minimized.
This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code.
bjorn3
force-pushed
the
emscripten_always_wasm_eh
branch
from
24d9697 to
9b7623a
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
TaKO8Ki
approved these changes
Jun 3, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 3, 2026
…r=TaKO8Ki Remove -Zemscripten-wasm-eh This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code. This is the final step of rust-lang#112195.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 3, 2026
Rollup of 7 pull requests Successful merges: - #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2) - #156928 (Remove -Zemscripten-wasm-eh) - #157236 (Reorganize `tests/ui/issues` [3/N]) - #157294 (Split coroutine layout computation to its own file) - #157328 (windows: Elide division-by-zero checks in Instant::now()) - #157331 (Rewrite target checking for `#[link]`) - #157336 (Enable `clippy::mem_replace_with_default`)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 3, 2026
…r=TaKO8Ki Remove -Zemscripten-wasm-eh This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code. This is the final step of rust-lang#112195.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 3, 2026
…r=TaKO8Ki Remove -Zemscripten-wasm-eh This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code. This is the final step of rust-lang#112195.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 3, 2026
…r=TaKO8Ki Remove -Zemscripten-wasm-eh This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code. This is the final step of rust-lang#112195.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was necessary when transitioning from JS to wasm exception handling on Emscripten. Enough time has probably passed that we no longer need to support JS exception handling on Emscripten. This enables cleaning up a fair bit of code.
This is the final step of #112195.