Conversation
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #54767) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased. |
| CloneShim(did, ty) => { | ||
| did.visit_with(visitor) || | ||
| ty.visit_with(visitor) | ||
| DropGlue(did, ty) => { |
There was a problem hiding this comment.
It looks like this can also be unified with the FnPtrShim | CloneShim arm?
There was a problem hiding this comment.
I tried it at first, but it doesn't typecheck: expected reference, found enum std::option::Option.
There was a problem hiding this comment.
OK. (One could argue that the fact that code that looks like its all the same types in fact is not, is itself another cleanup opportunity ...)
|
@bors r+ |
|
📌 Commit 04b99bc has been approved by |
bors
added
S-waiting-on-bors
Cleanup rustc/ty part 2 The second part of cleanups and minor improvements for rustc/ty. - improve allocations - calculate span after a possible early continue - simplify some patterns - mark a comment as FIXME - whitespace fixes The PR is independent from from the first part.
Cleanup rustc/ty part 2 The second part of cleanups and minor improvements for rustc/ty. - improve allocations - calculate span after a possible early continue - simplify some patterns - mark a comment as FIXME - whitespace fixes The PR is independent from from the first part.
|
☀️ Test successful - status-appveyor, status-travis |
4 participants
The second part of cleanups and minor improvements for rustc/ty.
The PR is independent from from the first part.