fixes rust-lang#56766

[saleemjaffer]

fixes #56766

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[saleemjaffer]

r? @estebank

[estebank]

Can you add a test to src/test/ui/parser/doc-inside-trait-item.rs:

trait User{
    fn test();
    /// empty doc
    //~^ ERROR found a documentation comment that doesn't document anything
}
fn main() {}

and run ./x.py test src/test/ui --bless and add the new test and its corresponding generated .stderr file?

[estebank]

For everything between 6636 and 6644 you can replace it with self.span_fatal_err(self.prev_span, Error::UselessDocComment).emit();, like in

rust/src/libsyntax/parse/parser.rs

Line 5290 in fcfc796

s.span_fatal_err(s.prev_span, Error::UselessDocComment).emit();

[saleemjaffer]

#57333 (comment)

@estebank This is the reason I used struct_span_err_with_code. Do we not need that now?

[pnkfelix]

(indeed, this does not seem like it needs to be a fatal error; I concur with @saleemjaffer's choice to use a non-fatal error here.)

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0f0ddda7:start=1552451371479680683,finish=1552451448956299056,duration=77476618373
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---

[00:03:21] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:21] tidy error: /checkout/src/test/ui/parser/doc-inside-trait-item.rs: missing trailing newline
[00:03:22] some tidy checks failed
[00:03:22] 
[00:03:22] 
[00:03:22] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:22] 
[00:03:22] 
[00:03:22] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:22] Build completed unsuccessfully in 0:00:47
[00:03:22] Build completed unsuccessfully in 0:00:47
[00:03:22] Makefile:68: recipe for target 'tidy' failed
[00:03:22] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:003e61d1
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Mar 13 04:34:20 UTC 2019
---
travis_time:end:064afad9:start=1552451661684368928,finish=1552451661689762848,duration=5393920
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:11965edf
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1dcf7220
travis_time:start:1dcf7220
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:171e1360
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[Dylan-DPC-zz]

ping from triage @saleemjaffer you need to address the failing test

[saleemjaffer]

This was fixed. All tests seem to be passing.

[Dylan-DPC-zz]

@estebank this is ready for a review

[Centril]

Ping from triage, @estebank, we eagerly await your review!

[pnkfelix]

@bors r? pnkfelix

[pnkfelix]

@bors r+

[bors]

📌 Commit d258481 has been approved by pnkfelix

[Centril]

r? @pnkfelix

[estebank]

Apologies for the unresponsiveness over the past week. I've been sporadically online.