This repository was archived by the owner on Feb 13, 2020. It is now read-only.
Fix passing options to Sauce Connect#344
Open
Ostrzy wants to merge 2 commits into
Open
Conversation
Contributor
|
Hey, thanks for the commit! Weird, I thought I fixed the What shell are you using? I'm not entirely sure whether shell escaping is standard or not, that'd be my only concern. Oh, and... There are no tests. Yet. >.> |
Author
|
I am using zsh, but when I'm trying to pass Sauce.config do |config|
tunnel_name = "LOCAL(#{ENV['SAUCE_USERNAME']})"
config[:connect_options] = { tunnel_identifier: "'#{tunnel_name}'" }
config["tunnel-identifier"] = tunnel_name
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when some options are passed to Sauce Connect using
it is simply ignored because only first option (which is always
readyfile) is return in the first block execution ofcollect.Additionally I've added some basic escaping for passed parameters using
'- in my case tunnel name wasLOCAL(username)and it was simply failing when passed directly to shell as an option.I wanted to create some spec for that, but didn't have any good idea how to test it.