Skip to content
This repository was archived by the owner on Feb 13, 2020. It is now read-only.

Fix passing options to Sauce Connect #344

Open
Ostrzy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix passing options to Sauce Connect #344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e48ba1c
Fix ignoring additional options passed to Sauce Connect
Ostrzy Jul 6, 2015
631e36f
Some basic options escaping
Ostrzy Jul 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gems/sauce-connect/lib/sauce/connect.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def connect
formatted_cli_options = array_of_formatted_cli_options_from_hash(cli_options)

command_args = ['-u', @config.username, '-k', @config.access_key]
command_args << formatted_cli_options
command_args += formatted_cli_options

command = "exec #{find_sauce_connect} #{command_args.join(' ')} 2>&1"

Expand Down Expand Up @@ -192,7 +192,7 @@ def self.ensure_connected(*args)
def array_of_formatted_cli_options_from_hash(hash)
hash.collect do |key, value|
opt_name = key.to_s.gsub("_", "-")
return "--#{opt_name} #{value}"
"--#{opt_name} '#{value}'"
end
end

Expand Down