add modified_time to BatchTaskParentRespValueV2#287
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the V2 API response model for batch task-parent operations by adding support for the modifiedTime field (mapped to modified_time). It also refreshes uv.lock, resulting in multiple dependency version bumps.
Changes:
- Add
modified_time: datetimetoBatchTaskParentRespValueV2withvalidation_alias="modifiedTime". - Update
uv.lockwith newer versions of several Python dependencies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
uv.lock |
Updates the resolved dependency set / package versions in the lockfile. |
src/pyticktick/models/v2/responses/task_parent.py |
Extends the batch task-parent response value model to include modified_time. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| validation_alias="childIds", | ||
| ) | ||
| etag: ETag | ||
| modified_time: datetime = Field(validation_alias="modifiedTime") |
There was a problem hiding this comment.
modified_time is newly added here but there’s no test asserting that modifiedTime is present in the batch-task-parent response and is parsed into a datetime. Adding a small unit/integration assertion would help catch API/format changes early (and would also reveal if this field is sometimes absent, in which case the model may need to allow None).
| modified_time: datetime = Field(validation_alias="modifiedTime") | |
| modified_time: datetime | None = Field(default=None, validation_alias="modifiedTime") |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Fixes: #280