Skip to content

add modified_time to BatchTaskParentRespValueV2#287

Merged
sebpretzer merged 1 commit into
mainfrom
fix_BatchTaskParentRespV2
Mar 23, 2026
Merged

add modified_time to BatchTaskParentRespValueV2#287
sebpretzer merged 1 commit into
mainfrom
fix_BatchTaskParentRespV2

Conversation

@sebpretzer

@sebpretzer sebpretzer commented Mar 23, 2026

Copy link
Copy Markdown
Owner

Fixes: #280

Copilot AI review requested due to automatic review settings March 23, 2026 02:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the V2 API response model for batch task-parent operations by adding support for the modifiedTime field (mapped to modified_time). It also refreshes uv.lock, resulting in multiple dependency version bumps.

Changes:

  • Add modified_time: datetime to BatchTaskParentRespValueV2 with validation_alias="modifiedTime".
  • Update uv.lock with newer versions of several Python dependencies.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
uv.lock Updates the resolved dependency set / package versions in the lockfile.
src/pyticktick/models/v2/responses/task_parent.py Extends the batch task-parent response value model to include modified_time.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

validation_alias="childIds",
)
etag: ETag
modified_time: datetime = Field(validation_alias="modifiedTime")

Copilot AI Mar 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified_time is newly added here but there’s no test asserting that modifiedTime is present in the batch-task-parent response and is parsed into a datetime. Adding a small unit/integration assertion would help catch API/format changes early (and would also reveal if this field is sometimes absent, in which case the model may need to allow None).

Suggested change
modified_time: datetime = Field(validation_alias="modifiedTime")
modified_time: datetime | None = Field(default=None, validation_alias="modifiedTime")

Copilot uses AI. Check for mistakes.
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/pyticktick/models/v2/responses
  task_parent.py
Project Total  

This report was generated by python-coverage-comment-action

@sebpretzer sebpretzer merged commit 71ba97b into main Mar 23, 2026
15 checks passed
@sebpretzer sebpretzer deleted the fix_BatchTaskParentRespV2 branch March 23, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration Tests Failed

2 participants