Skip to content

add modified_time to BatchTaskParentRespValueV2 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebpretzer merged 1 commit into from
Mar 23, 2026
Merged

add modified_time to BatchTaskParentRespValueV2 #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pyticktick/models/v2/responses/task_parent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

from __future__ import annotations

from datetime import datetime

from pydantic import Field

from pyticktick.models.v2.models import BaseModelV2
Expand All @@ -23,6 +25,7 @@ class BatchTaskParentRespValueV2(BaseModelV2):
validation_alias="childIds",
)
etag: ETag
modified_time: datetime = Field(validation_alias="modifiedTime")

Copilot AI Mar 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified_time is newly added here but there’s no test asserting that modifiedTime is present in the batch-task-parent response and is parsed into a datetime. Adding a small unit/integration assertion would help catch API/format changes early (and would also reveal if this field is sometimes absent, in which case the model may need to allow None).

Suggested change
modified_time: datetime = Field(validation_alias="modifiedTime")
modified_time: datetime | None = Field(default=None, validation_alias="modifiedTime")

Copilot uses AI. Check for mistakes.


class BatchTaskParentRespV2(BaseModelV2):
Expand Down
Loading
Loading