Textmate Syntax file generation for LSL and SLua - #120
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Co-authored-by: Tapple Gao <tapplek@gmail.com>
Co-authored-by: Tapple Gao <tapplek@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
| @@ -0,0 +1,398 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | |||
There was a problem hiding this comment.
Have you sanity checked these files in a textmate highlighter? I don't know how to do that
There was a problem hiding this comment.
The Slua one is already in use here, https://slua-playground.wlf.io
Tested the lsl one mostly using https://www.leskoff.com/s02050-0 probably need a cleaner solution but that was fast an simple 😝
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
punctuation
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
HaroldCindy
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
In general, it looks alright. There's certainly a lot of wonkiness with the nested functions inside other functions, but that's not anything we don't do elsewhere.
I imagine some of that could be abstracted out but... this is a repo for (mostly) straightforward codegen with deterministic outputs. So long as the generated code looks fine, the codegen code can have some warts :)
I do have a few comments though, lmk if there's anything I can clarify!
|
|
||
| ### Licenses | ||
|
|
||
| Copyright (c) JohnnyMorganz All rights reserved. |
There was a problem hiding this comment.
The easiest way to comply with the license is to shove them into comments in the output .tmLanguage, rather than just linking them. I believe it would be sufficient to say "Based on , Copyright (year) (so and so) - MIT license" in the relevant plist comments since the body of the MIT license is already shipped with this repo.
There was a problem hiding this comment.
It was like that. WolfGang changed it as the attribution was getting a bit long: c645623. I'm happy either way
There was a problem hiding this comment.
Yep, the MIT license is fairly explicit about this. If we ever give someone a copy of the tmLanguage file separately from this repo (which we will, through the JSON-RPC bridge), we need to include a copy of the full MIT license and the relevant copyright holders to be compliant.
It's why you get dozens of pages about zlib and curl license information in the credits of various games.
There was a problem hiding this comment.
added: d2df52c
It only seemed to be a requirement of the slua files, not lsl files, so I didn't change the lsl files
Signed-off-by: Wolfgang <wolfgang@wlf.io>
Signed-off-by: Wolfgang <wolfgang@wlf.io>
HaroldCindy
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just one pending note about including the third-party license details in the files where they're relevant and this should be good to merge.
Adds basic template base generation of textmate syntax files for both LSL and JSON
I chose to use template that I insert the relevant parts into instead of generating the whole document in a schema, as that would be ALLOT more code, unless more libraries were introduced and i am under the impression less dependencies and so forth is better, due to places this may need to be run.
Closes #9