Exclude integer and class from generated files - #180
Draft
tapple wants to merge 16 commits into
Draft
Conversation
tapple
commented
Jul 11, 2026
| <string>constant.numeric.hex.luau</string> | ||
| <key>match</key> | ||
| <string>\b0_*[xX]_*[\da-fA-F_]*(?:[eE][\+\-]?_*\d[\d_]*(?:\.[\d_]*)?)?</string> | ||
| <string>\b0_*[xX]_*[\da-fA-F_]*(?:i|[eE][\+\-]?_*\d[\d_]*(?:\.[\d_]*)?)?</string> |
Contributor
Author
There was a problem hiding this comment.
The only integer/class change this doesn't exclude is the 4i syntax in the markdown file, as it was added in the template and not in the generator. But, I think that's the most harmless part of the change
This was referenced Jul 11, 2026
tapple
marked this pull request as ready for review
July 13, 2026 21:18
tapple
marked this pull request as draft
July 13, 2026 21:25
tapple
marked this pull request as ready for review
July 13, 2026 21:33
tapple
marked this pull request as draft
July 14, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integerandclassare part of luau, but, for the moment, they are disabled in slua by fflags. Mark them as such and exclude them from all generated files exceptEmbeddedBuiltinDefinitions.cpp. This also makes the generated files backwards-compatable with Luau 0.710EmbeddedBuiltinDefinitions.cpp#122