Luau 0.715 integer library - #176
Open
tapple wants to merge 9 commits into
Open
Conversation
This was referenced Jul 11, 2026
tapple
force-pushed
the
715-integer
branch
2 times, most recently
from
July 13, 2026 15:00
554c0d4 to
6f821d0
Compare
tapple
marked this pull request as ready for review
July 13, 2026 21:22
tapple
marked this pull request as draft
July 14, 2026 14:33
tapple
marked this pull request as ready for review
August 4, 2026 16:42
HaroldCindy
reviewed
Aug 4, 2026
| { | ||
| "name": "constant.numeric.decimal.luau", | ||
| "match": "(?:\\d[\\d_]*(?:\\.[\\d_]*)?|\\.\\d[\\d_]*)(?:[eE][\\+\\-]?_*\\d[\\d_]*(?:\\.[\\d_]*)?)?" | ||
| "match": "(?:\\d[\\d_]*(?:\\.[\\d_]*)?|\\.\\d[\\d_]*)(?:i|[eE][\\+\\-]?_*\\d[\\d_]*(?:\\.[\\d_]*)?)?" |
Collaborator
There was a problem hiding this comment.
is this correct? Wouldn't this allow 1.1i?
Contributor
Author
There was a problem hiding this comment.
I'll add a unit test upstream and let you know
Contributor
Author
There was a problem hiding this comment.
Changes submitted upstream: JohnnyMorganz/Luau.tmLanguage#31
HaroldCindy
approved these changes
Aug 5, 2026
HaroldCindy
left a comment
HaroldCindy
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks! Just one question about the regex for decimals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbeddedBuiltinDefinitions.cpp#122As of Luau 0.729, integers are still experimental, and I don't plan to put them in the generated files. But I need them for
EmbeddedBuiltinDefinitions.cpp#181 . Integers are removed again in the next PR in this series, #180 . You probably want to review this and #180 at the same time. That's why this PR is marked ready for review dispite SLua not even containing Luau 0.715 yet