fix: change environment saving in HDR Environment. - #221
Merged
Felix Frank (feliopterix) merged 1 commit intoJul 31, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #221 +/- ##
==========================================
+ Coverage 99.69% 99.70% +0.01%
==========================================
Files 141 141
Lines 7435 7441 +6
Branches 1723 1737 +14
==========================================
+ Hits 7412 7419 +7
+ Misses 23 22 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Felix Frank (feliopterix)
force-pushed
the
fix/enrivonment-wrong-background-cache
branch
from
July 30, 2026 11:53
936cd3d to
d1790ec
Compare
Dennis Höllmann (Deristes)
approved these changes
Jul 30, 2026
Felix Frank (feliopterix)
deleted the
fix/enrivonment-wrong-background-cache
branch
July 31, 2026 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
The current implementation leads to errors when instantiating dive (without auto-starting), then changing the scene background, then starting render process.
This happens in Shopware Scene Editor atm: We instantiate dive, load the scene resources, apply them in dive and then start rendering.
2. What does this change do, exactly?
Extend the background management in the HDR Environment so that it always restores the correct scene background.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist