Skip to content

fix: change environment saving in HDR Environment. - #221

Merged
Felix Frank (feliopterix) merged 1 commit into
trunkfrom
fix/enrivonment-wrong-background-cache
Jul 31, 2026
Merged

fix: change environment saving in HDR Environment.#221
Felix Frank (feliopterix) merged 1 commit into
trunkfrom
fix/enrivonment-wrong-background-cache

Conversation

@feliopterix

Copy link
Copy Markdown
Contributor

1. Why is this change necessary?

The current implementation leads to errors when instantiating dive (without auto-starting), then changing the scene background, then starting render process.

This happens in Shopware Scene Editor atm: We instantiate dive, load the scene resources, apply them in dive and then start rendering.

2. What does this change do, exactly?

Extend the background management in the HDR Environment so that it always restores the correct scene background.

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@feliopterix
Felix Frank (feliopterix) requested a review from a team as a code owner July 30, 2026 11:38
@feliopterix Felix Frank (feliopterix) added the service/shopping-experience Issues and PRs related to this service. label Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.70%. Comparing base (d33e39c) to head (d1790ec).
⚠️ Report is 11 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #221      +/-   ##
==========================================
+ Coverage   99.69%   99.70%   +0.01%     
==========================================
  Files         141      141              
  Lines        7435     7441       +6     
  Branches     1723     1737      +14     
==========================================
+ Hits         7412     7419       +7     
+ Misses         23       22       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@feliopterix
Felix Frank (feliopterix) merged commit 9d6ee19 into trunk Jul 31, 2026
11 checks passed
@feliopterix
Felix Frank (feliopterix) deleted the fix/enrivonment-wrong-background-cache branch July 31, 2026 09:17
@octo-sts octo-sts Bot mentioned this pull request Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service/shopping-experience Issues and PRs related to this service.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants