feat: QuickView Dive states - #226
Merged
Merged
Conversation
Felix Frank (feliopterix)
added
the
service/shopping-experience
Felix Frank (feliopterix)
force-pushed
the
feat/quick-view-state
branch
from
August 6, 2026 08:37
13ea3fa to
37f541d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #226 +/- ##
==========================================
- Coverage 99.69% 99.67% -0.02%
==========================================
Files 141 146 +5
Lines 7435 7802 +367
Branches 1723 1809 +86
==========================================
+ Hits 7412 7777 +365
- Misses 23 25 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| ); | ||
| dive.clock.addTicker(orbitController); | ||
|
|
||
| const state = new (await import('@shopware-ag/dive/state')).State( |
Contributor
There was a problem hiding this comment.
Why no direct import 🫣
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
We want to apply whole states through the QuickView plugin of dive. Currently QuickView only support single urls/models.
2. What does this change do, exactly?
SetStateActionthat strictly applies a state completely to a scene (clears the scene, strict set!).GetStateActionthat return the complete state in the State plugin (replacesGetAllSceneDataAction).OrbitController.BoundingBoxclass.QuickViewUrifork toQuickViewplugin function (to quick-view single model files).QuickViewStatefork toQuickViewplugin function (to quick-view whole states).AddObjectActionto return Promises of added scene objects (Promise because of model fetching).UpdateObjectActionto return Promises of added scene objects (Promise because of model fetching).GetAllSceneDataAction(replaced byGetStateAction).3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist