fix: Do not forward query string to child processes#20
Merged
Conversation
Jonas Elfering (keulinho)
force-pushed
the
codex/fix-installer-query-string-env
branch
from
4f02615 to
eb31d70
Compare
Jonas Elfering (keulinho)
force-pushed
the
codex/fix-installer-query-string-env
branch
from
eb31d70 to
c7798d8
Compare
Jonas Elfering (keulinho)
changed the title
Michael Telgmann (mitelg)
approved these changes
May 20, 2026
Soner (shyim)
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
QUERY_STRING.QUERY_STRINGis not visible in a spawned PHP child process.Why
Symfony Runtime 7.4.12 changed argv handling for security hardening and clears CLI argv whenever
QUERY_STRINGis present. The web-installer starts Shopware console commands such assystem:update:prepareandsystem:update:finishfrom a web request. IfQUERY_STRINGleaks into the child process environment, those commands are effectively executed as plainbin/console, which exits successfully after printing the command list.That leaves update finalization incomplete: Composer has updated the Shopware packages, but assets are not installed, so the Administration can render a new Vite asset hash that does not exist in
public/bundles. This showed up in shopware/shopware#16910 as acceptance update failures after the Symfony 7.4.12 release.Validation
vendor/bin/phpunit Tests/Services/StreamedCommandResponseGeneratorTest.phpcomposer cs:checkvendor/bin/phpstan analyse --memory-limit=1G