Skip to content

fix: Do not forward query string to child processes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soner (shyim) merged 1 commit into from
May 21, 2026
Merged

fix: Do not forward query string to child processes #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Services/StreamedCommandResponseGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ class StreamedCommandResponseGenerator
public function run(array $params, callable $finish): StreamedResponse
{
$process = new Process($params);
$process->setEnv(['COMPOSER_HOME' => sys_get_temp_dir() . '/composer']);
/** @phpstan-ignore-next-line False prevents Symfony Process from forwarding inherited environment variables. */
$process->setEnv([
'COMPOSER_HOME' => sys_get_temp_dir() . '/composer',
// The installer starts CLI commands from a web request. Symfony Runtime
// 7.4.12+ clears argv when QUERY_STRING is present, so do not forward it.
'QUERY_STRING' => false,
]);

// Read process timeout from environment or use default value
$timeout = Platform::getEnv('SHOPWARE_INSTALLER_TIMEOUT');
Expand Down
24 changes: 24 additions & 0 deletions Tests/Services/StreamedCommandResponseGeneratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,30 @@ public function testRunJSON(): void
static::assertSame('foo' . \PHP_EOL . '{"success":true}', $content);
}

public function testRunJSONDoesNotForwardQueryStringToChildProcesses(): void
{
$_SERVER['QUERY_STRING'] = 'shopwareVersion=6.7.9999999.9999999';
$_ENV['QUERY_STRING'] = 'shopwareVersion=6.7.9999999.9999999';
putenv('QUERY_STRING=shopwareVersion=6.7.9999999.9999999');

try {
$response = (new StreamedCommandResponseGenerator())->runJSON([
\PHP_BINARY,
'-r',
'echo getenv("QUERY_STRING") === false ? "clean" : "leaked";',
]);

ob_start();
$response->sendContent();
$content = ob_get_clean();

static::assertSame('clean{"success":true}', $content);
} finally {
unset($_SERVER['QUERY_STRING'], $_ENV['QUERY_STRING']);
putenv('QUERY_STRING');
}
}

public function testCustomTimeoutFromEnv(): void
{
$customTimeout = 333.0;
Expand Down
Loading