refactor(native-charts-ng): deprecate SiNativeChartsNgModule#1656
Draft
akashsonune wants to merge 1 commit intomainfrom
Draft
refactor(native-charts-ng): deprecate SiNativeChartsNgModule#1656akashsonune wants to merge 1 commit intomainfrom
akashsonune wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates SiNativeChartsNgModule to encourage direct import of individual components, which is a good practice for improving application bundle size. The change is clear and aligns with the goal of modernizing the library's structure. The provided suggestion refines the wording of the deprecation message to better match the project's UX writing guidelines, which is a valid improvement.
akashsonune
force-pushed
the
refactor/deprecate-si-native-charts-module
branch
2 times, most recently
from
b841e82 to
1072aeb
Compare
DEPRECATED: `SiNativeChartsNgModule` is deprecated, import individual components instead. Separate entry points are available for each component, allowing applications to import components from specific entry points.
akashsonune
force-pushed
the
refactor/deprecate-si-native-charts-module
branch
from
1072aeb to
05069d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPRECATED:
SiNativeChartsNgModuleis deprecated, import individual components instead. Separate entry points are available for each component, allowing applications to import components from specific entry points.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: