Skip to content

refactor(date-range-filter): reduce change detections to update values #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spliffone merged 1 commit into from
Mar 28, 2026
Merged

refactor(date-range-filter): reduce change detections to update values #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions projects/element-ng/date-range-filter/si-relative-date.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<si-number-input
class="form-control mb-4"
[aria-label]="valueLabel()"
[ngModel]="offset()"
(ngModelChange)="updateValue($event)"
[value]="offset()"
(valueChange)="updateValue($event ?? 0)"
/>
<si-select
class="form-control"
min="0"
[ariaLabel]="unitLabel()"
[options]="offsetList()"
[ngModel]="unit()"
(ngModelChange)="changeUnit($event)"
[value]="unit()"
(valueChange)="changeUnit($event)"
/>
17 changes: 5 additions & 12 deletions projects/element-ng/date-range-filter/si-relative-date.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const ONE_DAY = ONE_MINUTE * 60 * 24;
@Component({
imports: [SiRelativeDateComponent],
template: `<si-relative-date
[enableTimeSelection]="enableTimeSelection"
[enableTimeSelection]="enableTimeSelection()"
[value]="value()"
[unitLabel]="unitLabel"
[valueLabel]="valueLabel"
Expand All @@ -24,9 +24,9 @@ const ONE_DAY = ONE_MINUTE * 60 * 24;
})
class TestHostComponent {
readonly value = signal(0);
enableTimeSelection = false;
unitLabel = t(() => $localize`:@@SI_DATE_RANGE_FILTER.UNIT:Unit`);
valueLabel = t(() => $localize`:@@SI_DATE_RANGE_FILTER.UNIT:Unit`);
readonly enableTimeSelection = signal(false);
readonly unitLabel = t(() => $localize`:@@SI_DATE_RANGE_FILTER.UNIT:Unit`);
readonly valueLabel = t(() => $localize`:@@SI_DATE_RANGE_FILTER.UNIT:Unit`);
}

describe('SiRelativeDateComponent', () => {
Expand All @@ -43,12 +43,6 @@ describe('SiRelativeDateComponent', () => {
btn?.dispatchEvent(new Event('mouseup'));
};

beforeEach(() =>
TestBed.configureTestingModule({
imports: [SiRelativeDateComponent, TestHostComponent]
})
);

beforeEach(() => {
fixture = TestBed.createComponent(TestHostComponent);
component = fixture.componentInstance;
Expand Down Expand Up @@ -101,7 +95,6 @@ describe('SiRelativeDateComponent', () => {
element.querySelector<HTMLElement>('si-select .select')?.click();
await fixture.whenStable();
document.querySelector<HTMLElement>('.dropdown-menu [data-id=weeks]')?.click();
await fixture.whenStable();

inputAction('.inc');
await fixture.whenStable();
Expand All @@ -111,7 +104,7 @@ describe('SiRelativeDateComponent', () => {
});

it('handles time selection', async () => {
component.enableTimeSelection = true;
component.enableTimeSelection.set(true);
await fixture.whenStable();

element.querySelector<HTMLElement>('si-select .select')?.click();
Expand Down
2 changes: 0 additions & 2 deletions projects/element-ng/date-range-filter/si-relative-date.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
signal,
SimpleChanges
} from '@angular/core';
import { FormsModule } from '@angular/forms';
import { SiNumberInputComponent } from '@siemens/element-ng/number-input';
import {
SelectOption,
Expand All @@ -32,7 +31,6 @@ interface OffsetOption extends SelectOption<string> {
@Component({
selector: 'si-relative-date',
imports: [
FormsModule,
SiNumberInputComponent,
SiSelectComponent,
SiSelectSingleValueDirective,
Expand Down
Loading