refactor(date-range-filter): reduce change detections to update values#1686
Open
refactor(date-range-filter): reduce change detections to update values#1686
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the si-relative-date component and its tests to reduce change detection cycles by moving away from FormsModule and using fixture.detectChanges() instead of await fixture.whenStable() in tests. The changes are generally good, but I found a couple of issues in the tests. There is a focused test suite (fdescribe) that needs to be removed, and one of the tests is missing necessary detectChanges calls which could make it flaky. Please see my comments for details.
projects/element-ng/date-range-filter/si-relative-date.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/element-ng/date-range-filter/si-relative-date.component.spec.ts
Show resolved
Hide resolved
spliffone
force-pushed
the
refactor/relative-date-drop-ngmodel
branch
3 times, most recently
from
d8c953b to
0ebeda9
Compare
spike-rabbit
requested changes
Mar 20, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
@dr-itz can you please have a look here as well.
projects/element-ng/date-range-filter/si-relative-date.component.spec.ts
Show resolved
Hide resolved
spliffone
force-pushed
the
refactor/relative-date-drop-ngmodel
branch
from
0ebeda9 to
e7a00f3
Compare
spike-rabbit
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngModelrequire an extra cycle to propagate changes which requires extra ticks or setTimeouts in the test cases, this isn't necessary when we directly use the value + changes.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: