Fix audio dropping issues in Jetpack Telecom integration - #14887
Open
yrezgui wants to merge 1 commit into
Open
Conversation
- Replaced `setActive()` with `answer(callType)` for incoming calls in `TelecomCallController`'s `Activate` command block, as Jetpack Telecom requires incoming calls to be explicitly answered. - Enforced waiting for a successful `CallControlResult.Success` before dispatching `AudioManagerCommand.Start` to the `ActiveCallManager`, ensuring that the WebRTC audio engine does not begin recording or playing before Telecom has actually initialized the active media route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
setActive()withanswer(callType)for incoming calls inTelecomCallController'sActivatecommand block, as Jetpack Telecom requires incoming calls to be explicitly answered.CallControlResult.Successbefore dispatchingAudioManagerCommand.Startto theActiveCallManager, ensuring that the WebRTC audio engine does not begin recording or playing before Telecom has actually initialized the active media route.