Skip to content

Fix audio dropping issues in Jetpack Telecom integration #14887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yrezgui wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

Fix audio dropping issues in Jetpack Telecom integration #14887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions app/src/main/java/org/thoughtcrime/securesms/service/webrtc/TelecomCallController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import android.telecom.DisconnectCause
import androidx.annotation.RequiresApi
import androidx.core.app.NotificationManagerCompat
import androidx.core.telecom.CallAttributesCompat
import androidx.core.telecom.CallControlResult
import androidx.core.telecom.CallEndpointCompat
import androidx.core.telecom.CallsManager
import kotlinx.coroutines.channels.Channel
Expand All @@ -21,6 +22,7 @@ import org.thoughtcrime.securesms.keyvalue.SignalStore
import org.thoughtcrime.securesms.recipients.Recipient
import org.thoughtcrime.securesms.recipients.RecipientId
import org.thoughtcrime.securesms.webrtc.CallNotificationBuilder
import org.thoughtcrime.securesms.webrtc.audio.AudioManagerCommand
import org.thoughtcrime.securesms.webrtc.audio.SignalAudioManager

sealed class TelecomCommand {
Expand Down Expand Up @@ -179,8 +181,17 @@ class TelecomCallController(
for (command in commandChannel) {
when (command) {
is TelecomCommand.Activate -> {
val result = setActive()
Log.i(TAG, "setActive result: $result")
val result = if (isOutgoing) {
setActive()
} else {
val callType = if (isVideoCall) CallAttributesCompat.CALL_TYPE_VIDEO_CALL else CallAttributesCompat.CALL_TYPE_AUDIO_CALL
answer(callType)
}
Log.i(TAG, "activate result: $result")
if (result is CallControlResult.Success) {
ActiveCallManager.sendAudioManagerCommand(context, AudioManagerCommand.Start())
Log.i(TAG, "AudioManagerCommand.Start fired for callId=$callId recipientId=$recipientId")
}
needToResetAudioRoute = false
}
is TelecomCommand.Disconnect -> {
Expand Down
Loading