fix(timer): show days in formatUsageDuration for durations >= 24h#228
Merged
sirmalloc merged 4 commits intosirmalloc:mainfrom Mar 15, 2026
Merged
fix(timer): show days in formatUsageDuration for durations >= 24h#228sirmalloc merged 4 commits intosirmalloc:mainfrom
sirmalloc merged 4 commits intosirmalloc:mainfrom
Conversation
Durations of 24+ hours now display a days component instead of raw hours (e.g. "1d 12hr 30m" instead of "36hr 30m"). Applies to both normal and compact formats. Fixes sirmalloc#210.
…ration Unify compact/normal branches into a single code path differing only in hour label and separator. Zero duration now displays "0m" instead of "0hr"/"0h".
5 tasks
|
I created something similar but a bit different here #235. mine doesnt automatically show days: it adds another key bind: "y", (out of "day" but d and a are taken) that sets a format option to times to show days and hours instead of hours and minutes. |
Default weekly reset timers to day-based formatting while adding an hours-only toggle and keeping preview text aligned with live rendering. Also move custom keybind visibility back into widgets and clear disabled toggle metadata when those options become unavailable in the editor.
# Conflicts: # src/utils/renderer.ts
Owner
|
I'll publish this whenever the next release goes out, I'm trying to get a few more PRs merged in before then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatUsageDuration()now displays a days component for durations >= 24 hours (e.g.1d 12hr 30minstead of36hr 30m)1d12h30min compact mode)0minstead of0hr/0hFixes #210
Test plan
1d 1hr,1d 12hr 30m,7d)1d1h,1d12h30m,7d)0min both modesbun run lintpasses