feat: add days+hours display format to weekly reset timer#235
Closed
jubishop wants to merge 3 commits intosirmalloc:mainfrom
Closed
feat: add days+hours display format to weekly reset timer#235jubishop wants to merge 3 commits intosirmalloc:mainfrom
jubishop wants to merge 3 commits intosirmalloc:mainfrom
Conversation
Add a new "days+hours" toggle (keybind 'd') to the weekly reset timer widget that displays remaining time as "6d 12h" instead of "156hr 30m". This format is more readable for the weekly time scale. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
sorry one sec I cant use (d) here because its delete |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
this is very similar but not exactly the same as #228. id be happy with either. |
5 tasks
Owner
|
Went with #228, added a (h)ours toggle and defaulted to showing days. |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
y) to the weekly reset timer widget6d 12hrinstead of156hr 30m, which is more readable at the weekly time scaleformatUsageDurationDaysHours()utility for days/hours formattingTest plan
formatUsageDurationDaysHours()covering edge cases (0hr, hours-only, days-only, days+hours)🤖 Generated with Claude Code