Use protocol-grpc 0.13 APIs - #7
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
use-call-routing
branch
from
August 16, 2026 23:14
168019e to
58c2b94
Compare
samuel-williams-shopify
changed the title
samuel-williams-shopify
force-pushed
the
use-call-routing
branch
2 times, most recently
from
August 16, 2026 23:23
24d22fa to
1edb11e
Compare
samuel-williams-shopify
force-pushed
the
use-call-routing
branch
from
August 16, 2026 23:58
1edb11e to
e2d4b1c
Compare
samuel-williams-shopify
changed the title
samuel-williams-shopify
marked this pull request as ready for review
August 17, 2026 00:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the routing and metadata APIs released in protocol-grpc 0.13.0.
Route.parseand build test paths withRoute.build.Metadata.buildand extract response metadata withMetadata.extract.Call.for(request, response)only after the response exists, keeping the call fully initialized and its response read-only.protocol-grpc ~> 0.13.0and remove the temporary Git commit pin.Protocol::GRPC::Methodsnamespace.Validation:
bundle exec sus test/async/grpc/client.rb test/async/grpc/dispatcher.rbbundle exec bake testbundle exec rubocop(35 files, no offenses)bundle exec bake decode:index:coverage lib(26/26 public definitions documented)