Introduce gRPC route helpers - #8
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
call-routing
branch
from
August 16, 2026 22:50
df6b841 to
712f5e9
Compare
samuel-williams-shopify
force-pushed
the
call-routing
branch
from
August 16, 2026 23:05
712f5e9 to
fda7de5
Compare
samuel-williams-shopify
force-pushed
the
call-routing
branch
2 times, most recently
from
August 16, 2026 23:19
aea594d to
016ef41
Compare
samuel-williams-shopify
force-pushed
the
call-routing
branch
from
August 16, 2026 23:23
016ef41 to
fa49477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
Protocol::GRPC::Routeas the namespace for parsing and building gRPC request paths.Route.parse(path)returns the service and method names.Route.build(service_name, method_name)returns the canonical request path.Interface#pathusesRoute.build.Methods.build_pathandMethods.parse_pathremain as compatibility wrappers.This lets async-grpc route requests without constructing a partially initialized
Call.Validation:
bundle exec bake test(232 tests, 420 assertions)bundle exec rubocop(58 files, no offenses)bundle exec bake decode:index:coverage lib(104/104 public definitions documented)