fix(Android): guard against re-adding an attached fragment in ScreenStack.onUpdate#4157
Open
JacquesLeupin wants to merge 1 commit into
Open
Conversation
…tack.onUpdate Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an
IllegalStateException: Fragment already added: ScreenStackFragmentcrash inScreenStack.onUpdate.When the top screen is translucent and
visibleBottom's fragment is not added, the re-attach loop adds every wrapper fromvisibleBottomupward without checking whether it is already attached. If a fragment abovevisibleBottomis still attached — we hit this in production after background/resume cycles with atransparentModalon top andenableFreeze(true)— theaddthrows on commit.Closes #4156.
Changes
!newTop.fragment.isAddedguard in the sibling branch below.dismissedWrappersare exempt from the skip: their removal is queued earlier in the same transaction, so remove + add is the existing (legal) re-attach path and behavior there is unchanged.The guard only changes behavior in states that currently throw — for any wrapper that isn't attached, the transaction is identical to before.
Test plan
:react-native-screens:compileDebugKotlinpasses with the change.Checklist