Skip to content

fix(Android): guard against re-adding an attached fragment in ScreenStack.onUpdate #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacquesLeupin wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix(Android): guard against re-adding an attached fragment in ScreenStack.onUpdate #4157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,12 @@ class ScreenStack(
screenWrappers
.asSequence()
.dropWhile { it !== visibleBottom } // ignore all screens beneath the visible bottom
// Skip fragments that are still attached, otherwise the transaction throws
// "Fragment already added" - e.g. when visibleBottom's fragment got detached
// while fragments above it stayed attached. Dismissed wrappers are exempt:
// their removal is queued earlier in this transaction, so adding them back
// is the legal remove + add re-attach path.
.filter { !it.fragment.isAdded || dismissedWrappers.contains(it) }
.forEach { wrapper ->
// TODO: It should be enough to dispatch this on commit action once.
transaction.add(id, wrapper.fragment).runOnCommit {
Expand Down
Loading