You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously Every sync cycle (every 10 seconds by default) would unconditionally:
Delete the LLDP_LOC_CHASSIS table from Redis
Write all chassis attributes back to Redis for the LLDP_LOC_CHASSIS table,
This leads to race conditions, since there is a possibility to perform an snmp query at the same time leading to missing data: 2025 Oct 19 00:41:14.530572 sonic WARNING snmp#snmp-subagent [sonic_ax_impl] WARNING: Missing lldp_loc_man_addr from APPL DB
The change which is done compares new chassis data with the cached version
Only performs DB operations (delete + set) if data has actually changed
Skips all DB writes when chassis data is unchanged
@keboliu is it a must fix for 202505? As the description said, there is a rare condition to trigger it.
I suggest not merge it to 202505, since 202511 is coming soon.
@keboliu is it a must fix for 202505? As the description said, there is a rare condition to trigger it. I suggest not merge it to 202505, since 202511 is coming soon.
interesting, normally, the chassis info is not changed after system boots up. how did you hit this failure?
This is our results for the past 30 days on 202505.
interesting, normally, the chassis info is not changed after system boots up. how did you hit this failure? This is our results for the past 30 days on 202505.
The only failure is not related to chassis info.
@ZhaohuiS we observed the test failure only once and it was not reproducible, Chassis info is not changed, but the sync function is called every 10 seconds which means there is data deletion and addition every 10 seconds, which is not necessary if there is no change to the data, which is why the cache is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously Every sync cycle (every 10 seconds by default) would unconditionally:
Delete the LLDP_LOC_CHASSIS table from Redis
Write all chassis attributes back to Redis for the LLDP_LOC_CHASSIS table,
This leads to race conditions, since there is a possibility to perform an snmp query at the same time leading to missing data:
2025 Oct 19 00:41:14.530572 sonic WARNING snmp#snmp-subagent [sonic_ax_impl] WARNING: Missing lldp_loc_man_addr from APPL DBThe change which is done compares new chassis data with the cached version
Only performs DB operations (delete + set) if data has actually changed
Skips all DB writes when chassis data is unchanged
Unit test:
Required for 202505 branch