Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lldp_syncd/daemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ def sync(self, parsed_update):
for k, v in chassis_update.items():
self.db_connector.set(self.db_connector.APPL_DB,
LldpSyncDaemon.LLDP_LOC_CHASSIS_TABLE, k, v, blocking=True)
self.chassis_cache = chassis_update
logger.debug("sync'd: {}".format(json.dumps(chassis_update, indent=3)))

new, changed, deleted = self.cache_diff(self.interfaces_cache, parsed_update)
Expand Down
27 changes: 27 additions & 0 deletions tests/test_lldpSyncDaemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,30 @@ def test_changed_interface(self):
self.assertEqual(jo[k], 'Ethernet1')
else:
jo[k] = db.get_all(db.APPL_DB, k)

def test_chassis_cache_no_db_calls_when_unchanged(self):
"""
Test that database operations are not called when chassis data hasn't changed.
"""
# First sync to populate chassis_cache
parsed_update = self.daemon.parse_update(self._json)
self.daemon.sync(parsed_update)
initial_cache = self.daemon.chassis_cache.copy()

# Sync again with same data - DB operations should NOT be called
parsed_update_same = self.daemon.parse_update(self._json)

with mock.patch.object(self.daemon.db_connector, 'delete') as mock_delete, \
mock.patch.object(self.daemon.db_connector, 'set') as mock_set:

self.daemon.sync(parsed_update_same)

# Verify chassis DB operations were NOT called
chassis_deletes = [c for c in mock_delete.call_args_list
if len(c[0]) > 1 and c[0][1] == 'LLDP_LOC_CHASSIS']
chassis_sets = [c for c in mock_set.call_args_list
if len(c[0]) > 1 and c[0][1] == 'LLDP_LOC_CHASSIS']

self.assertEqual(len(chassis_deletes), 0)
self.assertEqual(len(chassis_sets), 0)
self.assertEqual(self.daemon.chassis_cache, initial_cache)
Loading