Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 16, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Jan 16, 2026

🤖 Augment PR Summary

Summary: Fixes sourcemeta::codegen::compile so schema canonicalization respects the provided default dialect/ID when a schema omits $schema.

Changes:

  • Passes `default_dialect`/`default_id` through to `SchemaTransformer::apply` during canonicalization
  • Adds a regression test covering the `default_dialect` parameter for draft 2020-12

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 30ca39b into main Jan 16, 2026
12 checks passed
@jviotti jviotti deleted the default-dialect branch January 16, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants