Skip to content

Fix broken default dialect behavior #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
Jan 16, 2026
+22 −4
Merged

Fix broken default dialect behavior #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ir/ir.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ auto compile(const sourcemeta::core::JSON &input,
sourcemeta::core::SchemaTransformer canonicalizer;
sourcemeta::core::add(canonicalizer,
sourcemeta::core::AlterSchemaMode::Canonicalizer);
[[maybe_unused]] const auto canonicalized{
canonicalizer.apply(schema, walker, resolver,
[](const auto &, const auto, const auto,
const auto &) { assert(false); })};
[[maybe_unused]] const auto canonicalized{canonicalizer.apply(
schema, walker, resolver,
[](const auto &, const auto, const auto, const auto &) { assert(false); },
default_dialect, default_id)};
assert(canonicalized.first);

// --------------------------------------------------------------------------
Expand Down
18 changes: 18 additions & 0 deletions test/ir/ir_2020_12_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,24 @@ TEST(IR_2020_12, test_1) {
EXPECT_SYMBOL(std::get<IRScalar>(result.at(0)).symbol);
}

TEST(IR_2020_12, default_dialect_parameter) {
const sourcemeta::core::JSON schema{sourcemeta::core::parse_json(R"JSON({
"type": "string"
})JSON")};

const auto result{sourcemeta::codegen::compile(
schema, sourcemeta::core::schema_walker,
sourcemeta::core::schema_resolver, sourcemeta::codegen::default_compiler,
"https://json-schema.org/draft/2020-12/schema")};

using namespace sourcemeta::codegen;

EXPECT_EQ(result.size(), 1);

EXPECT_IR_SCALAR(result, 0, String, "");
EXPECT_SYMBOL(std::get<IRScalar>(result.at(0)).symbol);
}

TEST(IR_2020_12, test_2) {
const sourcemeta::core::JSON schema{sourcemeta::core::parse_json(R"JSON({
"$schema": "https://json-schema.org/draft/2020-12/schema",
Expand Down