Fix of signed/unsigned mismatch in variables maxWriteSize and amtToWrite#49
Open
George-Doge wants to merge 1 commit into
Open
Fix of signed/unsigned mismatch in variables maxWriteSize and amtToWrite#49George-Doge wants to merge 1 commit into
George-Doge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed variable type of
amtToWritefrominttouint16_tsince it is derived as a difference ofuint16_tvariables, in order to fix problems raised in issue #48.Following that I changed a mismatch of variable
maxWriteSizewhich was declared asint16_tbut it was assigned a value of variable withuint16_ttype. Lastly, to fix another error about comparison of signed and unsigned variables I added an explicit cast to the if statement after declaration ofmaxWriteSize.