Skip to content

Fix of signed/unsigned mismatch in variables maxWriteSize and amtToWrite #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
George-Doge wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix of signed/unsigned mismatch in variables maxWriteSize and amtToWrite #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SparkFun_External_EEPROM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,8 +816,8 @@ int ExternalEEPROM::write(uint32_t eepromLocation, const uint8_t *dataToWrite, u
// Serial.print("bufferSize: ");
// Serial.println(bufferSize);

int16_t maxWriteSize = settings.pageSize_bytes;
if (maxWriteSize > I2C_BUFFER_LENGTH_TX - settings.addressSize_bytes)
uint16_t maxWriteSize = settings.pageSize_bytes;
if (maxWriteSize > (uint16_t)I2C_BUFFER_LENGTH_TX - settings.addressSize_bytes)
maxWriteSize =
I2C_BUFFER_LENGTH_TX -
settings.addressSize_bytes; // Arduino has 32 byte limit. We loose 1 or 2 bytes to the EEPROM address
Expand All @@ -830,7 +830,7 @@ int ExternalEEPROM::write(uint32_t eepromLocation, const uint8_t *dataToWrite, u
while (recorded < bufferSize)
{
// Limit the amount to write to either the page size or the Arduino limit of 30
int amtToWrite = bufferSize - recorded;
uint16_t amtToWrite = bufferSize - recorded;

// Serial.print("amtToWrite: ");
// Serial.println(amtToWrite);
Expand Down