Fix VipsDriver save() without path and format() being ignored#321
Merged
Conversation
The VipsDriver was missing originalPath tracking and format fallback logic that GdDriver and ImagickDriver both have. This caused save() without a path to fail with "Unsupported format 'unknown'" and format() calls to be ignored when determining the output format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save()now falls back tooriginalPathwhen called without a path, matching GdDriver and ImagickDriver behaviorsave()now respects theformatproperty set viaformat(), instead of only looking at the path extension$this->formatto null after saving, consistent with the other driversFixes #320