Skip to content

Fix VipsDriver save() without path and format() being ignored #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freekmurze merged 2 commits into from
Mar 1, 2026
+22 −2
Merged

Fix VipsDriver save() without path and format() being ignored #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66d8d47
Fix VipsDriver save() without path and format() being ignored
freekmurze Mar 1, 2026
49ddfbb
Avoid else in VipsDriver save()
freekmurze Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Drivers/Vips/VipsDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ class VipsDriver implements ImageDriver

protected Image $image;

protected string $originalPath;

protected ?string $format = null;

protected int $defaultQuality = 75;
Expand Down Expand Up @@ -81,6 +83,7 @@ protected function setImage(Image $image): static
public function loadFile(string $path, bool $autoRotate = true): static
{
$this->optimize = false;
$this->originalPath = $path;

// Use 'access' => 'sequential' to avoid libvips file caching issues
// when the same file path is overwritten between loads
Expand All @@ -103,7 +106,11 @@ public function driverName(): string

public function save(string $path = ''): static
{
$extension = strtolower(pathinfo($path, PATHINFO_EXTENSION));
if (! $path) {
$path = $this->originalPath;
}

$extension = $this->format ?? strtolower(pathinfo($path, PATHINFO_EXTENSION));

if ($this->quality && $extension === 'png') {
throw CannotOptimizePng::make();
Expand All @@ -124,7 +131,7 @@ public function save(string $path = ''): static
if (str_contains($message, 'is not a known file format') ||
str_contains($message, 'unsupported') ||
str_contains($message, 'unable to call')) {
throw UnsupportedImageFormat::make($extension ?: $this->format ?? 'unknown', $exception);
throw UnsupportedImageFormat::make($extension ?: 'unknown', $exception);
}

throw $exception;
Expand All @@ -134,6 +141,8 @@ public function save(string $path = ''): static
$this->optimizerChain->optimize($path);
}

$this->format = null;

return $this;
}

Expand Down
11 changes: 11 additions & 0 deletions tests/ImageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,17 @@
expect($targetImage->getWidth())->toEqual(200);
});

it('can save without a path to overwrite the original file', function (ImageDriver $driver) {
$targetFile = $this->tempDir->path("{$driver->driverName()}/save-without-path.jpg");

copy(getTestJpg(), $targetFile);

$driver->loadFile($targetFile)->greyscale()->save();

expect($targetFile)->toBeFile();
expect($targetFile)->toHaveMime('image/jpeg');
})->with('drivers');

it('works with transparent pngs', function (ImageDriver $driver) {
$targetFile = $this->tempDir->path("{$driver->driverName()}/saving-transparent-png.png");

Expand Down