changing ambiguous variable naming in BasicJsonParser.java#49837
Open
etaiami09-cmd wants to merge 3 commits intospring-projects:mainfrom
Open
changing ambiguous variable naming in BasicJsonParser.java#49837etaiami09-cmd wants to merge 3 commits intospring-projects:mainfrom
etaiami09-cmd wants to merge 3 commits intospring-projects:mainfrom
Conversation
fixed an ambiguous variable name - the name "values" makes no sense when working with a key-value pair, since a reader will associate it with the value only when it contains both a value and a key. Signed-off-by: Etai codes <etaiami09@gmail.com>
earlier search & replace accidentally overrode doc string Signed-off-by: Etai codes <etaiami09@gmail.com>
fixed another search & replace error Signed-off-by: Etai codes <etaiami09@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in parseMapInternal, inside the for loop that handles tokens from tokenize(json), there is a variable named "values" that should have a different name. Semantically, it holds the trimmed strings of the key and the value of the JSON pair, but someone reading the code might think it only holds the value of the pair.
This pull request changes the variable name to "rawSplit", because it was built off the untrimmed String array named "split" and because after that it is seperated into variables called rawKey and rawValue.