Skip to content

changing ambiguous variable naming in BasicJsonParser.java #49837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etaiami09-cmd wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

changing ambiguous variable naming in BasicJsonParser.java #49837

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79b0cd8
Update BasicJsonParser.java
etaiami09-cmd Mar 29, 2026
20c24d8
Update BasicJsonParser.java
etaiami09-cmd Mar 29, 2026
7d0d092
Update BasicJsonParser.java
etaiami09-cmd Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/spring-boot/src/main/java/org/springframework/boot/json/BasicJsonParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ private Map<String, Object> parseMapInternal(int nesting, String json) {
json = trimEdges(json, '{', '}').trim();
for (String pair : tokenize(json)) {
String[] split = StringUtils.split(pair, ":");
@Nullable String[] values = (split != null) ? StringUtils.trimArrayElements(split) : null;
Assert.state(values != null, () -> "Unable to parse '%s'".formatted(pair));
String rawKey = values[0];
String rawValue = values[1];
@Nullable String[] rawSplit = (split != null) ? StringUtils.trimArrayElements(split) : null;
Assert.state(rawSplit != null, () -> "Unable to parse '%s'".formatted(pair));
String rawKey = rawSplit[0];
String rawValue = rawSplit[1];
Assert.state(rawKey != null, () -> "rawKew is null in '%s'".formatted(pair));
Assert.state(rawKey.startsWith("\"") && rawKey.endsWith("\""),
"Expecting double-quotes around field names");
Expand Down