log client version ID on server side#1412
Conversation
MattShirley
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1412 +/- ##
===========================================
+ Coverage 88.62% 89.27% +0.64%
===========================================
Files 99 103 +4
Lines 3498 3887 +389
Branches 426 514 +88
===========================================
+ Hits 3100 3470 +370
- Misses 328 341 +13
- Partials 70 76 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
Ok - this is a good start. I guess next step is to record this somewhere
| create_kibana_link=create_kibana_link, | ||
| ) | ||
|
|
||
| @app.before_request |
There was a problem hiding this comment.
This seems like it is unnecessarily frequent. Couldn't we just do this on the Login message?
There was a problem hiding this comment.
What would be the login route for the client? We could log when a token refresh happens or a transformation is submitted.
There was a problem hiding this comment.
Exactly - so that's pretty much once per transform request and not when polling for results
There was a problem hiding this comment.
I've moved the global logger to only occur when a transformation is submitted, will update the client as well.
for more information, see https://pre-commit.ci
…com/ssl-hep/ServiceX into 832-track-version-numbers-of-client
for more information, see https://pre-commit.ci
2 participants
Logs client side client version when received as an HTTP header.
For issue: #832
Front end work: ssl-hep/ServiceX_frontend#736