add client version to custom HTTP header in servicex_adapter#734
Closed
MattShirley wants to merge 1 commit intomasterfrom
Closed
add client version to custom HTTP header in servicex_adapter#734MattShirley wants to merge 1 commit intomasterfrom
MattShirley wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 30 30
Lines 2191 2196 +5
=======================================
+ Hits 2155 2160 +5
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenGalewsky
requested changes
May 6, 2026
Contributor
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
Please update tests to verify this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add client version to HTTP header so the server can consume this information.
For issue: ssl-hep/ServiceX#832
Backend work: ssl-hep/ServiceX#1412