network: make the pubsub topic whitelist slot-aware (#2968 item 3)

[momosh-ssv]

Item 3 of #2968.

commons.Topics gated the Alan topic set on the coarse BooleFork() epoch snapshot while subscriptions derive per-slot from the transition-window predicate — so a node started inside the ~34-slot subsequent window whitelisted Boole-only yet legitimately subscribes to Alan topics for late pre-fork committee traffic, working only incidentally because topicsCtrl.Subscribe self-registers.

Topics now takes the evaluation slot explicitly and includes the Alan set whenever Alan traffic can still be valid at that slot (!BooleForkAtSlot(slot) || InBooleTransitionWindow(slot)), always including Boole; the sole caller (NewPubSub) passes EstimatedCurrentSlot(). The startup-snapshot design is unchanged — the snapshot just now matches the subscription policy at the same instant.

Deep review notes (passed): the include-Alan condition is logically identical to all three per-slot subscription-derivation sites in network/p2p; the whitelist gates subscriptions/peer-announcements (mesh membership), not message validation, and the widening is confined to the subsequent window where the fork design requires Alan traffic to flow; a node started past the window gets Boole-only with no Alan leak (Boole==0 guard verified). Five-phase table test covers pre-fork steady state, prior window, subsequent window (the bug), the exact first slot past the window (the boundary that closes Alan), and well post-fork.

[greptile-apps]

Greptile Summary

Updates the pubsub topic whitelist to use the current slot when deciding whether Alan topics remain valid.

• Includes Alan and Boole topics before the Boole fork and throughout its transition window.
• Retains only Boole topics after the subsequent transition window closes.
• Adds boundary-focused tests for pre-fork, prior-window, subsequent-window, and post-window behavior.

Confidence Score: 5/5

The PR appears safe to merge with the topic whitelist correctly aligned to the slot-aware subscription policy.

The changed predicate matches the existing transition behavior, its boundary cases are covered, and all callers of the modified Topics signature are updated.

Important Files Changed

Filename	Overview
network/commons/subnets.go	Makes topic selection slot-aware and aligns Alan inclusion with the existing Boole transition-window predicates.
network/commons/subnets_test.go	Adds comprehensive topic-set tests covering the fork transition phases and the first slot after the subsequent window.
network/topics/pubsub.go	Passes the estimated startup slot into the topic-whitelist construction; the repository's sole production caller is updated.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[NewPubSub startup] --> B[Estimate current slot]
    B --> C{Before Boole fork or in transition window?}
    C -->|Yes| D[Whitelist Alan and Boole topics]
    C -->|No| E[Whitelist Boole topics only]
    D --> F[Construct GossipSub filter]
    E --> F

Loading

_{Reviews (1): Last reviewed commit: "network: make the pubsub topic whitelist..." | Re-trigger Greptile}