[6.x] Fix collection listing search case insensitivity#14486
Open
joshuablum wants to merge 4 commits into6.xfrom
Open
[6.x] Fix collection listing search case insensitivity#14486joshuablum wants to merge 4 commits into6.xfrom
joshuablum wants to merge 4 commits into6.xfrom
Conversation
Contributor
|
Verified it fixes umlaut issue. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collection listing's search is only case insensitive with ascii characters. That leads to issues with languages using unicode (e.g. umlauts in German or Greek). PR updates the query builder's regex and
strtolowerto include multi-byte/unicode.Closes #14485.