Skip to content

[6.x] Fix collection listing search case insensitivity #14486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuablum wants to merge 4 commits into
base: 6.x
Choose a base branch
from
+10 −3
Open

[6.x] Fix collection listing search case insensitivity #14486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8fbd37
Add `u` regex option to include unicode
joshuablum Apr 13, 2026
f924134
Same here, `mb_strtolower` to make it work with unicode
joshuablum Apr 13, 2026
19d2e6e
Add test
joshuablum Apr 13, 2026
466cd3d
Merge remote-tracking branch 'origin/6.x' into fix-listing-search-cas…
duncanmcclean Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Query/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ protected function filterTestLike($item, $like)

$pattern = Pattern::sqlLikeToRegex($like);

return preg_match('/'.$pattern.'/im', (string) $item);
return preg_match('/'.$pattern.'/imu', (string) $item);
}

protected function filterTestNotLike($item, $like)
Expand All @@ -815,7 +815,7 @@ protected function filterTestNotLike($item, $like)

protected function filterTestLikeRegex($item, $pattern)
{
return preg_match("/{$pattern}/im", (string) $item);
return preg_match("/{$pattern}/imu", (string) $item);
}

protected function filterTestNotLikeRegex($item, $pattern)
Expand Down
2 changes: 1 addition & 1 deletion src/Query/EloquentQueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public function where($column, $operator = null, $value = null, $boolean = 'and'

if ($operator !== null && strtolower($operator) == 'like') {
$grammar = $this->builder->getConnection()->getQueryGrammar();
$this->builder->whereRaw('LOWER('.$grammar->wrap($this->column($column)).') LIKE ?', strtolower($value), $boolean);
$this->builder->whereRaw('LOWER('.$grammar->wrap($this->column($column)).') LIKE ?', mb_strtolower($value), $boolean);

return $this;
}
Expand Down
7 changes: 7 additions & 0 deletions tests/Data/Entries/EntryQueryBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,9 @@ public function entries_are_found_using_like($like, $expected)
'/ test',
'test /',
'test / test',
'Über dem Meer',
'über dem meer',
'Ärger',
])->each(function ($val, $i) {
EntryFactory::id($i)
->slug('post-'.$i)
Expand Down Expand Up @@ -999,6 +1002,10 @@ public static function likeProvider()
'%/' => ['/', 'test /'],
'/%' => ['/', '/ test'],
'%/%' => ['/', '/ test', 'test /', 'test / test'],
'%über%' => ['Über dem Meer', 'über dem meer'],
'%Über%' => ['Über dem Meer', 'über dem meer'],
'%ärger%' => ['Ärger'],
'%Ärger%' => ['Ärger'],
])->mapWithKeys(function ($expected, $like) {
return [$like => [$like, $expected]];
});
Expand Down
Loading