fix: update default value for enableWebsockets in View component#890
Merged
Conversation
🦋 Changeset detectedLatest commit: 32e628e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Updates the React Native Storybook View.getStorybookUI defaults so WebSocket support is enabled automatically when a WebSocket configuration is injected via globalThis.STORYBOOK_WEBSOCKET (e.g., from generated storybook.requires).
Changes:
- Change
enableWebsocketsdefault fromfalsetoBoolean(globalThis.STORYBOOK_WEBSOCKET)inView.getStorybookUI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/storybookjs/react-native/sessions/ec11a168-cf2c-46d8-aab4-c390a292e66d Co-authored-by: ndelangen <3070389+ndelangen@users.noreply.github.com>
Member
|
Can you add the changeset? |
…rybookjs/react-native into norbert/auto-detect-websocketenabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I made the
enableWebsocketsoption auto-enable, based on the generated config runtime.How to test
Provide environment variables for websockets, but don't explicitly setup
enableWebsocketsinside of.rnstorybook/index.tsx.The expected outcome is that the storybook connects to the given websocket address.