Skip to content

fix: update default value for enableWebsockets in View component #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 4 commits into from
May 12, 2026
Merged

fix: update default value for enableWebsockets in View component #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31b0809
fix: update default value for enableWebsockets in View component
ndelangen May 11, 2026
ef76194
docs: update enableWebsockets JSDoc to reflect auto-enable behavior
Copilot May 11, 2026
c784d1a
chore: add changeset for auto-detect websocket enabling in @storybook…
ndelangen May 12, 2026
32e628e
Merge branch 'norbert/auto-detect-websocketenabled' of github.com:sto…
ndelangen May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slick-ants-double.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@storybook/react-native': patch
---

auto-detect websocket enabling
4 changes: 2 additions & 2 deletions packages/react-native/src/View.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export type Params = {
hasStoryWrapper?: boolean;
/**
* Enable websockets for the storybook server to remotely control the storybook
* default: false
* default: automatically enabled when a websocket config is injected via storybook.requires (i.e. when STORYBOOK_WS_HOST is set), otherwise false
*/
enableWebsockets?: boolean;
query?: string;
Expand Down Expand Up @@ -264,7 +264,7 @@ export class View {

getStorybookUI = (params: Partial<Params> = {}) => {
const {
enableWebsockets = false,
enableWebsockets = !!globalThis.STORYBOOK_WEBSOCKET,
CustomUIComponent,
hasStoryWrapper: storyViewWrapper = true,
Comment thread
ndelangen marked this conversation as resolved.
} = params;
Expand Down
Loading