feat(comments): add createdAt sortBy + sortDir, deprecate new/old#13
Merged
Conversation
Mirrors the server change. Adds "createdAt" as the canonical comment time sort plus a "sortDir" param, and marks the directional aliases "new" (createdAt DESC) and "old" (createdAt ASC) deprecated — the server still accepts them (identical behavior, removed in v8) but responds with deprecation headers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the server change (comments sort parity with entities): adds
createdAtas the canonical comment time sort plus asortDirparam, and marks the directional aliasesnew(createdAt DESC) andold(createdAt ASC) deprecated.FetchManyCommentsProps.sortBy: addcreatedAt; keepnew/oldas@deprecatedmembers (server still accepts them, identical behavior, removed in v8, responds with deprecation headers).sortDir?: "asc" | "desc".Pairs with the server, monorepo, and docs PRs.
Verification:
tsc --noEmitclean.🤖 Generated with Claude Code