Skip to content

feat(comments): add createdAt sortBy + sortDir, deprecate new/old #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tsabary merged 1 commit into from
Jun 24, 2026
+14 −1
Merged

feat(comments): add createdAt sortBy + sortDir, deprecate new/old #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/modules/comments/fetchManyComments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,20 @@ export interface FetchManyCommentsProps extends SpaceReputationContextParams {
parentId?: string;
page?: number;
limit?: number;
sortBy?: "new" | "old" | "top" | "controversial";
sortBy?:
| "createdAt"
| "top"
| "controversial"
/** @deprecated Use "createdAt" instead. "new" is a directional alias for
* createdAt DESC, removed in v8; the server still accepts it (identical
* behavior) but responds with deprecation headers. */
| "new"
/** @deprecated Use "createdAt" with sortDir:"asc" instead. "old" is a
* directional alias for createdAt ASC, removed in v8; the server still
* accepts it (identical behavior) but responds with deprecation headers. */
| "old";
/** Sort direction for `sortBy: "createdAt"`. Defaults to "desc". */
sortDir?: "asc" | "desc";
include?: string;
sourceId?: string;
}
Expand Down
Loading