Skip to content

feat: advanced_extensions - #105

Merged
nielspardon merged 1 commit into
substrait-io:mainfrom
mbwhite:advanced_extensions
Oct 20, 2025
Merged

feat: advanced_extensions#105
nielspardon merged 1 commit into
substrait-io:mainfrom
mbwhite:advanced_extensions

Conversation

@mbwhite

@mbwhite mbwhite commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Adding the ability to pass in an 'advanced extension' to the relation builders.
Optional, but useful if needed.

Improves the level of function compared to the other libraries

@github-actions

Copy link
Copy Markdown

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@mbwhite
mbwhite force-pushed the advanced_extensions branch 2 times, most recently from 4431d73 to 2a7e64a Compare October 17, 2025 10:25
@mbwhite

mbwhite commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

Sorry - used Python 3.10+ syntax initially.

@tokoko

tokoko commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

3.9 has already reached EOL this month so you were technically correct to use 3.10+ syntax 😆 we should probably drop 3.9 from the tests and add 3.14 instead

@tokoko tokoko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@nielspardon

Copy link
Copy Markdown
Member

@mbwhite can you rebase and resolve the conflicts? thanks

Add support to the builders for suppling
 an (optional) advanced extension.

Signed-off-by: MBWhite <whitemat@uk.ibm.com>
@mbwhite
mbwhite force-pushed the advanced_extensions branch from 2a7e64a to d07a441 Compare October 20, 2025 15:18

@nielspardon nielspardon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mbwhite

@nielspardon
nielspardon merged commit fadc414 into substrait-io:main Oct 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants