fix: update protobuf dependency to v5.29.5 - #111
Conversation
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
In previous projects with protobufs the approach taken has been to avoid checking in the generated code; and have it created from a known level of the protobuf definitions; that way the generated code is always at the correct level and not something that might have created from any other level. Especially when the same proto definitions are used across projects with differing languages. Just an observations based on past experience. |
54bf9e3 to
ac6a3bf
Compare
- update protobuf to v5.29.5 - downgrade protoc in devcontainer to v29.5 - update nipunn1313-mypy buf plugin to v3.6.0 - regenerate proto Python code with protobuf v5.29.5 - update uv.lock Signed-off-by: Niels Pardon <par@zurich.ibm.com>
ac6a3bf to
90fcdea
Compare
Here we are checking it in to avoid extra dependencies (and build steps) when installing the Python package. |
This PR fixes the import issue by upgrading the
protobufdependency and related dependenciesto a consistent version.
fixes #110