chore: run tests with uv - #106
Conversation
|
@tokoko what do you think about updating the https://github.com/substrait-io/substrait-python/blob/main/CONTRIBUTING.md file? that feels a bit out of sync to me if we are using |
|
I guess we can do that, yeah. I've personally never used that conda environment, I'm fairly sure no one else is using it either. |
|
@tokoko @nielspardon using Happy to help here - testing or updating.. |
|
it looks like the issue is caused by a protobuf version incompatibility. the the older version only has |
|
Checked what I've got locally in Does the Update: Cloning this PR and running (python3.12) there aren't any issues with the tests... 🤷 It's the generation of the protos.. ah! |
|
I have a fix. will provide a separate PR |
|
this should fix it: #111 |
|
I fixed the tests in here as well. We can avoid bumping lower bound unnecessarily, especially when it's just test code. |
great, that should also work |
nielspardon
left a comment
There was a problem hiding this comment.
LGTM, just two typos I found in the markdown file
switches to using uv lockfile to run tests to make ci environment more reproducible.