Skip to content

Use typed throws#12

Merged
ktoso merged 11 commits into
swiftlang:mainfrom
colemancda:feature/typed-throws
Mar 24, 2026
Merged

Use typed throws#12
ktoso merged 11 commits into
swiftlang:mainfrom
colemancda:feature/typed-throws

Conversation

@colemancda
Copy link
Copy Markdown
Contributor

Also exports the error types as public API and removed an unused type.

Comment thread Sources/SwiftJavaJNICore/JavaDemanglingError.swift Outdated
Comment thread Sources/SwiftJavaJNICore/Mangling.swift Outdated
Comment thread Sources/SwiftJavaJNICore/VirtualMachine/LockedState.swift
Comment thread Sources/SwiftJavaJNICore/VirtualMachine/JavaVirtualMachine.swift Outdated
@ktoso
Copy link
Copy Markdown
Collaborator

ktoso commented Mar 23, 2026

Thanks but we need to prepare this some more for future with source stability when making enums public

@colemancda
Copy link
Copy Markdown
Contributor Author

Addressed feedback, let me know if any more changes are needed. My main use case is the JavaVirtualMachine.shared() call, but I wanted to make this change for all error throws so this can be part of the public API in the future, and downstream projects can catch the errors properly.

@colemancda colemancda requested a review from ktoso March 23, 2026 05:07
@ktoso ktoso merged commit 7d6584b into swiftlang:main Mar 24, 2026
51 checks passed
@colemancda colemancda deleted the feature/typed-throws branch March 24, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants