fix: use fast fee for hw transfer - #1089
Merged
Merged
Conversation
Trezor → spending funding was using the settings default fee tier (medium), which can resolve to 1 sat/vB and leave channel funding unconfirmed. Use fast instead and raise the estimate-unavailable fallback from 1 to 3 sat/vB. Fixes #1088 Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThis PR uses faster fees for hardware-wallet funding. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/viewmodels/TransferViewModel.kt | Uses the fast fee tier for hardware-wallet funding and raises the fallback fee rate to 3 sat/vB. |
| app/src/test/java/to/bitkit/viewmodels/TransferViewModelTest.kt | Verifies the fast fee request and updates the expected fallback fee rate. |
| changelog.d/next/1088.fixed.md | Documents the improved confirmation reliability for hardware-wallet transfers. |
Reviews (1): Last reviewed commit: "chore: rename changelog fragment" | Re-trigger Greptile
jvsena42
reviewed
Jul 16, 2026
Collaborator
Author
|
Tested end-to-end on mainnet (Trezor → spending / Blocktank channel open).
Fix confirmed end-to-end on mainnet. |
piotr-iohk
enabled auto-merge
July 17, 2026 08:52
Contributor
|
Failing e2e test seems valid on first glance, also note related issue #1034 |
piotr-iohk
force-pushed
the
fix/1088-hw-transfer-fast-fee
branch
from
July 17, 2026 10:14
f852500 to
5228c88
Compare
Collaborator
Author
jvsena42
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1088
This PR makes Trezor → spending funding use a faster on-chain fee rate so LSP channel funding confirms more reliably.
Description
Related iOS: synonymdev/bitkit-ios#633
Preview
N/A
QA Notes
Manual Tests
regression:Savings → Transfer → Spending: still works with the existing savings fee path.Automated Checks
TransactionSpeed.Fastand uses a 3 sat/vB fallback when fee lookup fails inTransferViewModelTest.kt.just test file TransferViewModelTest,just lint.Made with Cursor