Skip to content

fix: use fast fee for hw transfer #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotr-iohk merged 2 commits into from
Jul 17, 2026
Merged

fix: use fast fee for hw transfer #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7748ab3
fix: use fast fee for hw transfer
piotr-iohk Jul 16, 2026
5228c88
chore: rename changelog fragment
piotr-iohk Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions app/src/main/java/to/bitkit/viewmodels/TransferViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,10 +892,8 @@ class TransferViewModel @Inject constructor(
private suspend fun hwFundingSatsPerVByte(): ULong =
fetchHwFundingSatsPerVByte().getOrDefault(HW_FUNDING_FALLBACK_SATS_PER_VBYTE)

private suspend fun fetchHwFundingSatsPerVByte(): Result<ULong> {
val speed = settingsStore.data.first().defaultTransactionSpeed
return lightningRepo.getFeeRateForSpeed(speed)
}
private suspend fun fetchHwFundingSatsPerVByte(): Result<ULong> =
lightningRepo.getFeeRateForSpeed(TransactionSpeed.Fast)
Comment thread
piotr-iohk marked this conversation as resolved.

// endregion

Expand Down Expand Up @@ -1108,7 +1106,7 @@ class TransferViewModel @Inject constructor(
private const val HW_FUNDING_TX_VBYTES = 1_200uL

/** Minimum fallback fee rate when fee estimates are temporarily unavailable. */
private const val HW_FUNDING_FALLBACK_SATS_PER_VBYTE = 1uL
private const val HW_FUNDING_FALLBACK_SATS_PER_VBYTE = 3uL

/** Upper bound for reconnecting a known device before the UI asks for reconnect. */
private val HW_RECONNECT_TIMEOUT = 30.seconds
Expand Down
4 changes: 3 additions & 1 deletion app/src/test/java/to/bitkit/viewmodels/TransferViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import to.bitkit.models.HwFundingSignedTx
import to.bitkit.models.HwFundingTransaction
import to.bitkit.models.HwWallet
import to.bitkit.models.Toast
import to.bitkit.models.TransactionSpeed
import to.bitkit.models.TransferType
import to.bitkit.models.TransportType
import to.bitkit.models.safe
Expand Down Expand Up @@ -388,6 +389,7 @@ class TransferViewModelTest : BaseUnitTest() {
sut.onTransferToSpendingHwConfirm(order, DEVICE_ID)
advanceUntilIdle()

verify(lightningRepo).getFeeRateForSpeed(eq(TransactionSpeed.Fast), anyOrNull())
verify(hwWalletRepo).composeFundingTransaction(
eq(DEVICE_ID),
eq(order.payment?.onchain?.address.orEmpty()),
Expand Down Expand Up @@ -1023,7 +1025,7 @@ class TransferViewModelTest : BaseUnitTest() {
const val XPUB = "zpub-test"
const val TXID = "tx-abc"
const val FEE_RATE = 2uL
const val FALLBACK_FEE_RATE = 1uL
const val FALLBACK_FEE_RATE = 3uL
const val MINING_FEE = 1_250uL
}
}
1 change: 1 addition & 0 deletions changelog.d/next/1089.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hardware wallet transfers to spending now use a faster on-chain fee rate so funding confirms more reliably.
Loading